merge queue: embarking 2.28-maintenance (cae5086), #13609, #13593, #13647, #13634, #13611, #13645, #13625, #13617, #13581, #13649 and [#13601 + #13604 + #13632 + #13627 + #13636] together#13669
Closed
mergify[bot] wants to merge 32 commits into2.28-maintenancefrom
Conversation
`#deriving-path-encoding` is defined in two places, I _think_ this is the correct one to change. (cherry picked from commit 4c50cf7)
(cherry picked from commit d8da8f0)
Allows to copy the archive to a remote host and not get
error: cannot add path '/nix/store/01x2k4nlxcpyd85nnr0b9gm89rm8ff4x-source' because it lacks a signature by a trusted key
(cherry picked from commit 80a4293)
These tests have been collected from nixpkgs f870c6ccc8951fc48aeb293cf3e98ade6ac42668 usage of builtins.match for x86_64-linux eval system. At most 2 matching and non-matching cases are included for each encountered regex. This should hopefully add more confidence when possibly trying to switch the regex implementation in the future. (cherry picked from commit d555d6b)
How did this work before... * Added .direnv/ to gitignore (cherry picked from commit 58e34a2)
(cherry picked from commit 6badd21)
Co-authored-by: Valentin Gagarin <valentin@gagarin.work> (cherry picked from commit 633d391)
Co-authored-by: Valentin Gagarin <valentin@gagarin.work> (cherry picked from commit c0ceaa2)
The latter alias is deprecated in favor of the former, and produces a warning. (cherry picked from commit cfc15d6)
(cherry picked from commit 525078c)
(cherry picked from commit 57c72de)
This overload isn't actually necessary anywhere and doesn't make much sense. The pointers to `Value`s are themselves const, but the `Value`s are mutable. A non-const member function implies that the object itself can be modified but this doesn't make much sense considering the return type: `Value * const * `, which is a pointer to a constant array of pointers to mutable values. (cherry picked from commit 7b46eb9)
(cherry picked from commit 699db04)
(cherry picked from commit 785f386)
We shouldn't leak memory in unit tests in order to make enabling ASAN easier. (cherry picked from commit 55d12df)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully and will be merged soon. 🎉
Branch 2.28-maintenance (cae5086), #13609, #13593, #13647, #13634, #13611, #13645, #13625, #13617, #13581, #13649 and [#13601 + #13604 + #13632 + #13627 + #13636] are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of [#13601 + #13604 + #13632 + #13627 + #13636].
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:check-success=installer test on macoscheck-success=installer test on ubuntucheck-success=tests on macoscheck-success=tests on ubuntucheck-success=vm_testscheck-success = installer test on macoscheck-neutral = installer test on macoscheck-skipped = installer test on macoscheck-success = installer test on ubuntucheck-neutral = installer test on ubuntucheck-skipped = installer test on ubuntucheck-success = tests on macoscheck-neutral = tests on macoscheck-skipped = tests on macoscheck-success = tests on ubuntucheck-neutral = tests on ubuntucheck-skipped = tests on ubuntuRequired conditions to stay in the queue:
check-success = installer test on macosbuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-neutral = installer test on macosbuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-skipped = installer test on macosbuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-success = installer test on ubuntubuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-neutral = installer test on ubuntubuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-skipped = installer test on ubuntubuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-success = tests on macosbuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-neutral = tests on macosbuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-skipped = tests on macosbuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-success = tests on ubuntubuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-neutral = tests on ubuntubuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627check-skipped = tests on ubuntubuiltins.match(backport #13282) #13604listElems(backport #13360) #13632nix config checkworks (backport #13351) #13627